Skip to content

Update contributions.yaml #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025
Merged

Update contributions.yaml #68

merged 1 commit into from
Apr 9, 2025

Conversation

twisst
Copy link
Contributor

@twisst twisst commented Apr 5, 2025

fixes processing/processing-website#595 or at least the dead links that are in processing-contributions (mainly by adding mailto: to mail addresses)

Fixing dead links (mainly by adding mailto: to mail address)
Copy link

netlify bot commented Apr 5, 2025

Deploy Preview for processing-contributions ready!

Name Link
🔨 Latest commit 6cece72
🔍 Latest deploy log https://app.netlify.com/sites/processing-contributions/deploys/67f1278167b57f00086b9069
😎 Deploy Preview https://deploy-preview-68--processing-contributions.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@twisst twisst changed the title Update contributions.yaml Update contributions.yaml #595 Apr 5, 2025
@twisst twisst changed the title Update contributions.yaml #595 Update contributions.yaml Apr 5, 2025
@mingness
Copy link
Collaborator

mingness commented Apr 5, 2025

Hello @twisst , thanks for your work on this. I'm happy to merge this in, but as stated in the issue in the processing-website repo, this isn't a permanent solution. You've already done a lot for the issue, but would you be interested in taking a look at the script that makes the jsons? it is currently written in python, and is this file: https://github.com/processing/processing-contributions/blob/main/scripts/to_sources_jsons.py
No worries if you don't have further time for this, but do let me know.

@twisst
Copy link
Contributor Author

twisst commented Apr 9, 2025

Hi @mingness, the changes in this commit would go into the json's without changes to the conversion script. so that's separate from the conversion problems I mentioned in the issue. So you could just merge these changes as that is already a small improvement :-)

@twisst
Copy link
Contributor Author

twisst commented Apr 9, 2025

@mingness hang on, I get it now, contributions.yaml is also being recreated from other sources. That means the 'mailto:' needs to be added in either the script that updates contributions.yaml or in the script that makes the JSONs. It's just four broken links in this case or something, it's probably not worth the trouble :-)

@mingness
Copy link
Collaborator

mingness commented Apr 9, 2025

@twisst that's right, the contributions.yaml will get updated from the library properties files, so that's why it's not a permanent solution, and a more long term solution would be to update the script that converts the yaml file to the jsons. No worries, I'll merge this, and it will solve the issues for now.

@mingness mingness merged commit 635b78d into processing:main Apr 9, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dead links (The Internal Edition)
2 participants